Conversation
…yml as tag. In future we may need to remove the version from the image name.
DSchrupert
reviewed
Jun 13, 2019
Member
DSchrupert
left a comment
DSchrupert
left a comment
There was a problem hiding this comment.
Template should include:
- resource requests/limits
- liveness/readiness checks
- label for environment
resource requests/limits
liveness/readiness checks
label for environment
DSchrupert
approved these changes
Jun 21, 2019
BalloonWen
added a commit
that referenced
this pull request
Jun 26, 2019
* -init created template file
* -added kubernetes template for deploy and expose a service.
* -instead of using "test" as tag, using the version defined in config.yml as tag. In future we may need to remove the version from the image name.
* -added following to the kubernetes deploy template:
resource requests/limits
liveness/readiness checks
label for environment
stevehu
pushed a commit
that referenced
this pull request
Jul 3, 2019
* -init created template file
* -added kubernetes template for deploy and expose a service.
* -instead of using "test" as tag, using the version defined in config.yml as tag. In future we may need to remove the version from the image name.
* -added following to the kubernetes deploy template:
resource requests/limits
liveness/readiness checks
label for environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: #299
this will generate by default. don't want to add too many options in config file, if needs config to enable/disable this feature, maybe in future releases.