add NPE check before get "properties" property inside allOf/$ref/

[BalloonWen]

in some cases, there may not be properties
related issue: #386

[ddobrin]

@BalloonWen : small note: the issue is with oneOf.

Skipping the generation in case "properties" is not found is one issue.
Agreed that a lack of the node "properties" should not create a NPE. That is a good validation.

Would you create a second issue for oneOf encountered at that place, when there are no properties defined?

[BalloonWen]

@BalloonWen : small note: the issue is with oneOf.

Skipping the generation in case "properties" is not found is one issue.
Agreed that a lack of the node "properties" should not create a NPE. That is a good validation.

Would you create a second issue for oneOf encountered at that place, when there are no properties defined?

Hi @ddobrin , it happens in the place in "oneOf" but the root cause is "allOf", because the "CIdentifier" which is missing properties is under "Result400/allOf/$ref"

[ddobrin]

Yes, I agreed with the NPE.
The problem discussed with @miklish yesterday has actually 2 parts: this NPE, which I was not worried about, as it is a clear fix, and the generation of the correct oneOf related artifacts

[BalloonWen]

Yes, I agreed with the NPE.
The problem discussed with @miklish yesterday has actually 2 parts: this NPE, which I was not worried about, as it is a clear fix, and the generation of the correct oneOf related artifacts

I see, he discussed with us yesterday, but we feel a little bit confused, if it's not very urgent, let's discuss another round together, maybe in a meeting room. thank you.

[ddobrin]

@BalloonWen @miklish : I am not available to meet in person until next week, as I am working remotely this week.

We can discuss over Google hangouts or phone if you guys like.

My client sees it almost as a showstopper. Reach out offline if you like