Skip to content

Feat/388 generation of one of artifacts#389

Merged
stevehu merged 4 commits into1.6.xfrom
feat/388_generation_of_oneOf_artifacts
Oct 26, 2019
Merged

Feat/388 generation of one of artifacts#389
stevehu merged 4 commits into1.6.xfrom
feat/388_generation_of_oneOf_artifacts

Conversation

@jiachen1120
Copy link
Copy Markdown
Contributor

@jiachen1120 jiachen1120 commented Oct 9, 2019 •
edited
Loading

Related doc: networknt/light-rfcs#39
Related issue: #388

@miklish
Copy link
Copy Markdown

miklish commented Oct 24, 2019

Looks good!

As we discussed offline, it would be good to add some additional comments.

Also--in OpenApiGenerator.loadModel()--I think the code could be made clearer by changing the variable name of schemaQueue, currentSchema, currentSchemaKey, to something that describes the fact that these are schema elements and do not usually refer the root of a full schema. E.g.: Perhaps schemaElementQueue, currentElement, currentElementKey.

Other than that, I'm ready to approve.

@jiachen1120
Added comments
b013977 
Changed variable name to make code clearer
@jiachen1120
Copy link
Copy Markdown
Contributor Author

jiachen1120 commented Oct 24, 2019

@miklish Thanks for the helpful suggestion! I already added the comments and changed the variable name to be more specific :)

@miklish
Copy link
Copy Markdown

miklish commented Oct 24, 2019

Thanks @jiachen1120!

@ddobrin @stevehu Please review and approve the PR when you can.

@ddobrin
Copy link
Copy Markdown
Contributor

ddobrin commented Oct 25, 2019

Guys,
I can't test this feature out at this time, as we have API deliveries this week and I am busy with it.

I don't want to hold the codegen release up and I can test it next week. If I encounter issues, we can work on a new release.

I am leaving it up to @stevehu

@stevehu stevehu merged commit 1fbd90d into 1.6.x Oct 26, 2019
@stevehu stevehu deleted the feat/388_generation_of_oneOf_artifacts branch October 26, 2019 13:43
stevehu pushed a commit that referenced this pull request Oct 26, 2019
@jiachen1120 @stevehu
Feat/388 generation of one of artifacts (#389)
dc247d0 
* Handled oneOf artifact

* Enhanced the toString, hash, and equals methods

* Optimized the generation of abstract class

* Added comments
Changed variable name to make code clearer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehu stevehu stevehu approved these changes

@miklish miklish miklish approved these changes

@BalloonWen BalloonWen Awaiting requested review from BalloonWen

@ddobrin ddobrin Awaiting requested review from ddobrin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiachen1120 @miklish @ddobrin @stevehu