-
Notifications
You must be signed in to change notification settings - Fork 32
More features and refactoring #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…custom Diff subclasses if desired. Fixes #6
…tive to uid str in DSync.get()
…ault_delete() to _sync_from_diff_element()
|
Additionally:
|
dgarros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I'll try to integrate that with NI tomorrow to see how it's working with all these changes
…Model, add SKIP_UNMATCHED_* flags.
|
Sorry, one more. I started working on #9 and realized that it would require adding another boolean parameter to the This latest update fixes #9 by adding two more flags, I also added a |
dgarros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flags looks good, not sure about the names as well so let's go with that for now.
The other changes looks great too
Fixes #6, I think.
In brief - you can now optionally specify a
Diffsubclass when callingdiff_from,diff_to,sync_from, orsync_to. The main reason for doing this is that after creating and populating a Diff with all relevant data, we now call acomplete()callback on the Diff object; by default this does nothing, but a subclass could, for example, respond to this callback by printing the completed diff, saving it to a file, or writing it to a database.