Add order_children methods in Diff Object #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12
This PR restructure the
get_childrenmethod in the Diff object to leverage neworder_childrenmethods.By default get_children will check if a order_children method specific to each children is available (
order_children_sitefor site) or call theorder_children_default.Each order_children method needs to return an
IteratorofDiffElementand get_children is returning a global iterator with all children.Here is an example on how to order the sites in alphabetical order