Skip to content

Modernize NHS serial communication and add configurable port settings - #3543

Merged
jimklimov merged 2 commits into
networkupstools:masterfrom
Challado:codex/nhs-ser-3510-pr
Jul 25, 2026
Merged

Modernize NHS serial communication and add configurable port settings#3543
jimklimov merged 2 commits into
networkupstools:masterfrom
Challado:codex/nhs-ser-3510-pr

Conversation

@Challado

Copy link
Copy Markdown

Summary

  • Modernize the NHS serial communication implementation.
  • Add validated configuration for baud rate, data bits, parity, stop bits and flow control.
  • Add configurable serial read timeout and transmission pacing.
  • Preserve the driver's existing conditional compilation directives.
  • Improve resource handling, reconnection behavior and explanatory comments.
  • Bump the driver version from 0.04 to 0.05.

Related to #3510.

Testing

  • Successfully compiled the nhs_ser driver on Linux.
  • Runtime communication with UPS hardware has not yet been tested.

Signed-off-by: Lucas Bocchi <lucas.bocchii@gmail.com>
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

A ZIP file with standard source tarball and another tarball with pre-built docs for commit 4640bfc is temporarily available: NUT-tarballs-PR-3543.zip.

@AppVeyorBot

Copy link
Copy Markdown

Build nut 2.8.5.4978-master completed (commit caaf06ed63 by @)

@jimklimov jimklimov added enhancement serial port Connection stability issues Issues about driver<->device and/or networked connections (upsd<->upsmon...) going AWOL over time labels Jul 24, 2026
@jimklimov jimklimov added this to the 2.8.6 milestone Jul 24, 2026
@jimklimov

Copy link
Copy Markdown
Member

Thanks, looks great! Might be a worthwile pattern to address #2748 eventually :)

One bit that seems missing is an entry in NEWS.adoc and updates to the driver man page, please.

Signed-off-by: Lucas Willian Bocchi <lucas@lucas.inf.br>
@Challado

Copy link
Copy Markdown
Author

Added the requested documentation updates in commit 4640bfc:

  • Added a NEWS.adoc entry covering the nhs_ser serial communication changes.
  • Updated the nhs_ser man page with the supported baud-rate behavior and the new data bits, parity, stop bits, flow control, per-byte read timeout, and transmission pacing options.

Thanks!

@Challado

Challado commented Jul 24, 2026 via email

Copy link
Copy Markdown
Author

@AppVeyorBot

Copy link
Copy Markdown

Build nut 2.8.5.4982-master completed (commit 88ff3670c3 by @)

@jimklimov
jimklimov merged commit 6b6a18f into networkupstools:master Jul 25, 2026
101 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Connection stability issues Issues about driver<->device and/or networked connections (upsd<->upsmon...) going AWOL over time enhancement serial port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants