-
Notifications
You must be signed in to change notification settings - Fork 158
YOLOv3 benchmarking static input shape override #118
Conversation
markurtz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small comments
| return tmp_file.name, tmp_file | ||
|
|
||
|
|
||
| def _get_onnx_tensor_idx_shape(tensor: onnx.TensorProto, idx: int) -> int: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to move this get and set to generic utils in the sparseml.onnx package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. updated
kevinaer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending docstring nit
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks ben, looks good!
* YOLOv3 benchmarking static input shape override * updates from review comments * udate README with sparsezoo stubs * support for num-sockets, default num cores to None, update docs, updates from review
--image-shapedoes not match the ONNX model's static input shapetrain.pyto unwrap DP/DDP models before applying recipes--num-sockets