Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

@bfineran
Copy link
Contributor

@bfineran bfineran commented Mar 28, 2021

  • in YOLOv3 benchmarking, create a temporary ONNX model with the given input shape if --image-shape does not match the ONNX model's static input shape
  • fix for yolo train.py to unwrap DP/DDP models before applying recipes
  • support for --num-sockets

@bfineran bfineran requested review from a team and markurtz March 28, 2021 02:13
@bfineran bfineran self-assigned this Mar 28, 2021
Copy link
Member

@markurtz markurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small comments

return tmp_file.name, tmp_file


def _get_onnx_tensor_idx_shape(tensor: onnx.TensorProto, idx: int) -> int:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to move this get and set to generic utils in the sparseml.onnx package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. updated

kevinaer
kevinaer previously approved these changes Mar 29, 2021
Copy link
Contributor

@kevinaer kevinaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending docstring nit

@bfineran bfineran requested a review from a team March 29, 2021 22:10
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ben, looks good!

@bfineran bfineran requested a review from a team March 29, 2021 23:16
@bfineran bfineran merged commit 10c1121 into main Mar 30, 2021
@bfineran bfineran deleted the yolo-benchmark-input-shapes branch March 30, 2021 01:25
bfineran added a commit that referenced this pull request Mar 30, 2021
* YOLOv3 benchmarking static input shape override

* updates from review comments

* udate README with sparsezoo stubs

* support for num-sockets, default num cores to None, update docs, updates from review
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants