Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

@bfineran
Copy link
Contributor

@bfineran bfineran commented Feb 7, 2023

  • adds torch_all extra dependency which includes torch{audio,text,vision}
  • removes tensorboard as a torch dependency since it is an optional install for torch logging and may cause version conflicts for users with existing dependencies
  • moves the tensorboard deps to dev deps to unblock GHA testing

test_plan:
@rahul-tuli verified a fresh environment with a few intentionally adversarial preinstalled dependencies (newer tensorflow version, older flask version, older click version) was able to install a fresh build of sparseml[torch_all] and kick off an IC training run

@bfineran bfineran self-assigned this Feb 7, 2023
@bfineran bfineran marked this pull request as ready for review February 7, 2023 19:51
@bfineran bfineran merged commit 4bcc9ba into main Feb 8, 2023
@bfineran bfineran deleted the torch-all-dep branch February 8, 2023 16:17
bfineran added a commit that referenced this pull request Feb 8, 2023
* install extra option for torch_all

* add torchtext, remove tensorboard as a torch dep

* move tensorboard deps to dev deps to run tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants