This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[cherry-pick] fix propagation of mask creator objects in PT pruning modifier (#220) #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix propagation of mask creator objects in PT pruning modifier * quality - need type() to handle inheretence
bfineran
requested review from
kevinaer,
markurtz and
natuan
and removed request for
a team
Member
|
Can we also add a test for it so we can verify things are working? |
Contributor
Author
|
@dhuangnm the test file is updated in this PR to check that the correct mask creator is set |
Member
oh ok, cool thanks. |
Member
|
Can we update the version.py to 0.3.1 for the cherry-pick? |
markurtz
approved these changes
May 10, 2021
kevinaer
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug that defaults pytorch mask creators to be 'unstructured' in certain training flows
updates release version to 0.3.1 for this hotfix