Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

bug fix for torch ONNX export with >1 input #284

Merged
merged 4 commits into from
Jun 15, 2021
Merged

bug fix for torch ONNX export with >1 input #284

merged 4 commits into from
Jun 15, 2021

Conversation

@bfineran
Copy link
Contributor

@bfineran bfineran commented Jun 11, 2021

fixes the following issues:

  • if the model had exactly 2 inputs, tensors_module_forward would ignore the second by default
  • if multiple inputs were given as a List, (function typing allows for Any), torch.onnx.export would fail, inputs should be converted to a Tuple

@bfineran bfineran requested a review from a team June 11, 2021 20:55
@bfineran bfineran self-assigned this Jun 11, 2021
@bfineran bfineran requested review from markurtz, mgoin and natuan and removed request for a team June 11, 2021 20:55
@bfineran bfineran merged commit ebf9ff3 into main Jun 15, 2021
@bfineran bfineran deleted the torch-multi-inp-exp branch June 15, 2021 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@natuan natuan Awaiting requested review from natuan

@mgoin mgoin Awaiting requested review from mgoin

2 more reviewers

@kevinaer kevinaer kevinaer approved these changes

@markurtz markurtz markurtz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bfineran bfineran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bfineran @kevinaer @markurtz