Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

@natuan
Copy link
Contributor

@natuan natuan commented Jun 14, 2021

No description provided.

@natuan natuan requested review from a team, bfineran, markurtz and mgoin June 14, 2021 14:03
Base automatically changed from tuan/bert_tutorial to main June 14, 2021 15:31
Copy link
Member

@jeanniefinks jeanniefinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to another round of edits, may you do a search and replace on this phrase and add the serial comma?
CURRENT
checkpoint saving frequency and logging options
NEW
checkpoint saving frequency, and logging options

@natuan natuan force-pushed the tuan/bert_turotial_02 branch 3 times, most recently from 11a287b to 3afad1a Compare June 18, 2021 14:28
jeanniefinks
jeanniefinks previously approved these changes Jun 18, 2021
@markurtz
Copy link
Member

@natuan it doesn't look like the table is formatting correctly when viewing the tutorial file on github. Additionally, can we get an export image from the wandb runs to show in the tutorial?

Other than that looks good to me

@natuan natuan force-pushed the tuan/bert_turotial_02 branch from 6a60981 to 8448739 Compare June 20, 2021 17:02
…rt_using_recipes.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>
@natuan natuan merged commit 7676b27 into main Jun 21, 2021
@natuan natuan deleted the tuan/bert_turotial_02 branch June 21, 2021 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants