This repository was archived by the owner on Jun 3, 2025. It is now read-only.
initialize M-FAC grad buffer based on masks, not param values #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
requested review from
kevinaer,
mgoin and
natuan
and removed request for
a team
markurtz
previously approved these changes
Jun 14, 2021
markurtz
approved these changes
Jun 15, 2021
kevinaer
approved these changes
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
param values may be 0 irrespective of masks which may cause issues during M-FAC pruning. this change makes sure that the grad buffer stores gradients based on what params are not currently masked, not what's not currently 0.