-
Notifications
You must be signed in to change notification settings - Fork 157
Activation Bits Support + qconfig kwargs for QuantizationModifier #542
Conversation
fcea317 to
e99b870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed we need to have modifier properties to control both the weight and activation qconfig kwargs
|
@rahul-tuli pushed the discussed fix for propagating observer quant range |
37a93d3 to
a4955dd
Compare
Thanks, incorporated the requested changes! |
Fix: tests, test helper names, style Fix - Merge Conflicts Renamed - `enable_in4_activations` to `int4_activations`
a4955dd to
4cb3a46
Compare
Use: A copy of `activation_qconfig_kwargs` for overriding quant_max, quant_min values
…f hardcoding to 4 bits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks close! left a few comments then good from my end
f34644b to
95af573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more comment then good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6cf2160 to
ad4580c
Compare
ad4580c to
7f6ac86
Compare

Uh oh!
There was an error while loading. Please reload this page.