This repository was archived by the owner on Jun 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
[SparseZoo v2 Bridge] Save IC training artifacts to ModelDirectory directory #864
Merged
dbogunowicz
merged 11 commits into
feature/integration_w_sparsezoo_v2/main
from
feature/damian/integrate_w_sparsezoo_v2
Jul 8, 2022
Merged
[SparseZoo v2 Bridge] Save IC training artifacts to ModelDirectory directory #864
dbogunowicz
merged 11 commits into
feature/integration_w_sparsezoo_v2/main
from
feature/damian/integrate_w_sparsezoo_v2
Jul 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
reviewed
Jun 13, 2022
Contributor
bfineran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick note - let's land this onto a separate feature branch as well and merge when sparsezoo refactor is ready to go
tdg5
approved these changes
Jul 5, 2022
bfineran
reviewed
Jul 7, 2022
bfineran
approved these changes
Jul 7, 2022
bfineran
added a commit
that referenced
this pull request
Aug 1, 2022
* [SparseZoo v2 Bridge] Save IC training artifacts to ModelDirectory directory (#864) * initial commit * remove rubbish file * Update train.py * refactor export samples * change name of folders * working, time for refactoring * ready for review * Delete hehe.py * Update helpers.py * Apply suggestions from code review Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * first round of edits * first sweep through all files * checking if pytorch checks pass * second sweep through all files * third sweep through all files * Update README.md * Update README.md * Update README.md * fourth sweep through all files * fifth sweep through all files * Update integrations/keras/README.md * rolling back some edits after bens comment * remove notebook output * add back onnx dataloading + batching functionality + tests * pytorch logic, orgainization, completeness fixes * use final checkpoint in eval mode IC training Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> Co-authored-by: Benjamin <ben@neuralmagic.com>
dbogunowicz
added a commit
that referenced
this pull request
Aug 23, 2022
…rectory directory (#927) * [SparseZoo v2 Bridge] Save IC training artifacts to ModelDirectory directory (#864) * initial commit * remove rubbish file * Update train.py * refactor export samples * change name of folders * working, time for refactoring * ready for review * Delete hehe.py * Update helpers.py * Apply suggestions from code review Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * initial commit * Delete hehe.py * Update helpers.py * round of corrections after Ben's comments * edited wrong /if/ statement, correction applied * Update src/sparseml/pytorch/image_classification/utils/helpers.py * Update src/sparseml/pytorch/image_classification/utils/helpers.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * Update src/sparseml/transformers/utils/helpers.py * Update src/sparseml/transformers/utils/helpers.py * Update src/sparseml/transformers/utils/helpers.py * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * update the code * update src * fix quality * fix quality * Apply suggestions from code review * fix quality * reformat tests according to coreys suggestion Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creating the
ModelDirectorylocal directory from the direct output of the IC training procedure.To test:
feature/ci-cd-refactor/validationsbranchOutput: