This repository was archived by the owner on Jun 3, 2025. It is now read-only.
fix None type propagation issue when ConstantPruningModifier start_epoch > 0 #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
requested review from
anmarques,
kylesayrs and
natuan
and removed request for
a team
anmarques
approved these changes
Jun 17, 2022
kylesayrs
approved these changes
Jun 18, 2022
bfineran
added a commit
that referenced
this pull request
Jun 20, 2022
bfineran
added a commit
that referenced
this pull request
Jun 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this bug was exposed due to the rare case of
ConstantPruningModifier'sstart_epochbeing greater than zero in staged recipes.