This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Fix for ONNX export for quantized BERT models #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kylesayrs assigned for review |
bfineran
reviewed
Jul 8, 2022
src/sparseml/pytorch/sparsification/quantization/quantize_qat_export.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/quantization/quantize_qat_export.py
Outdated
Show resolved
Hide resolved
…export.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
natuan
previously approved these changes
Jul 8, 2022
Contributor
natuan
left a comment
natuan
left a comment
There was a problem hiding this comment.
LGTM, pending Ben's suggestion to delete the unused func
bfineran
approved these changes
Jul 8, 2022
natuan
approved these changes
Jul 8, 2022
anmarques
added a commit
that referenced
this pull request
Jul 11, 2022
* Remove quantization of identity branch on BERT models * Style and quality fixes. * Update src/sparseml/pytorch/sparsification/quantization/quantize_qat_export.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * Removed unused function Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
markurtz
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Bump up version id * Fix for ONNX export for quantized BERT models (#935) * Remove quantization of identity branch on BERT models * Style and quality fixes. * Update src/sparseml/pytorch/sparsification/quantization/quantize_qat_export.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * Removed unused function Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR does NOT remove quantization of the identity branch for ResNet models. This will require fixes on the model side as well. Will be addressed in a future PR.