Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

@natuan
Copy link
Contributor

@natuan natuan commented Mar 11, 2021

No description provided.

@natuan natuan requested a review from a team March 11, 2021 03:58
@natuan natuan force-pushed the tuan/pytorch2keras branch 2 times, most recently from 82b10df to a3d4354 Compare March 19, 2021 06:43
@natuan natuan changed the title [WIP] Convert models from Pytorch to Keras Convert models from Pytorch to Keras Mar 19, 2021
Copy link
Member

@markurtz markurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and will re-review once those are addressed other diffs land so this can be rebased

@@ -0,0 +1,347 @@
import re
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script needs to be copy righted as well, be sure to run make style

@natuan natuan changed the title Convert models from Pytorch to Keras [WIP] Convert models from Pytorch to Keras Mar 19, 2021
@natuan natuan force-pushed the tuan/pytorch2keras branch from a3d4354 to bb7be40 Compare March 21, 2021 22:31
@natuan natuan changed the title [WIP] Convert models from Pytorch to Keras Convert models from Pytorch to Keras Mar 21, 2021
@natuan natuan requested a review from a team March 21, 2021 22:33
Copy link
Contributor

@kevinaer kevinaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a few small nits

Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job getting this working @natuan!

@natuan natuan merged commit e05f2cb into main Mar 22, 2021
@natuan natuan deleted the tuan/pytorch2keras branch March 22, 2021 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants