This repository was archived by the owner on Jun 3, 2025. It is now read-only.
SparseZoo Table UI #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinaer
requested review from
a team,
bfineran,
markurtz and
natuan
and removed request for
a team
…d improved loading of tables
markurtz
suggested changes
Apr 22, 2021
Member
markurtz
left a comment
markurtz
left a comment
There was a problem hiding this comment.
A few minor things but overall looks good. We should definitely start thinking through what test cases would look like for these to keep it in good shape. Also, I think anything exported in these modules we should add docs for
src/ui/components/zoo-table/zoo-table-headers/zoo-table-headers-styles.jsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
At least from my previous experiences, enzyme with jest would be the best way to write tests for components. Definitely for post release will start filling out backlog of tests. |
markurtz
approved these changes
Apr 26, 2021
bfineran
approved these changes
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple dynamic table for sparsezoo models.
Core Features:
Remaining Work:
UI not finalized, comments made on UI should be left in this PR. They will be address on subsequent PR.
Including temporary urls for image classifications and object detection