This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Simplify saved recipes #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markurtz
approved these changes
Oct 8, 2021
Member
markurtz
left a comment
markurtz
left a comment
There was a problem hiding this comment.
This looks good for now, I do think there's more we can do here to generalize, though, so let's sync and continue iterating
KSGulin
pushed a commit
that referenced
this pull request
Mar 9, 2022
* Only save modifiers that change the model * Only save arch changing modifiers with the model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a model is trained with modifiers such as QAT or layer pruning, we save the entire recipe containing them and apply it again when the model is loaded (before applying a new recipe such as pruning on top of it). This change is to limit the saving to only modifiers that change the architecture of the models.