This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Refactor SparseML trainer for multiple tasks #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natuan
requested review from
a team,
bfineran,
markurtz,
mgoin and
spacemanidol
spacemanidol
approved these changes
Aug 13, 2021
bfineran
approved these changes
Aug 13, 2021
Comment on lines
+175
to
+176
| modifiers = [m.__class__.__name__ for m in manager.modifiers] | ||
| is_qat_recipe = "QuantizationModifier" in modifiers |
There was a problem hiding this comment.
Suggested change
| modifiers = [m.__class__.__name__ for m in manager.modifiers] | |
| is_qat_recipe = "QuantizationModifier" in modifiers | |
| is_qat_recipe = bool(manager.quantization_modifiers) |
KSGulin
pushed a commit
that referenced
this pull request
Mar 9, 2022
bfineran
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Cohere Model Release (#1) Cohere Model Release * Remove unnecessary files and code (#2) Some cleanup * Delete cohere-model directory (#3) * Make Fix (#5) * Pr fixes (#6) * fixes for pr * pr fixes for the format * pr fixes for the format * src/transformers/models/auto/tokenization_auto.py * Tokenizer test (#8) * tokenizer test * format fix * Adding Docs and other minor changes (#7) * Add modeling tests (#9) * Smol Fix (#11) * tokenization tests are fixed * format fixes * fix pr doc tests * fix pr doc tests * fix pr doc tests * fix pr style check * small changes in cohere.md * FIX: Address final comments for transformers integration (#13) * fix modeling final nits and add proper test file * for now leave empty tests * add integration test * push new test * fix modeling cohere (#14) * Update chat templates to use the new API (#15) --------- Co-authored-by: ahmetustun <ahmetustun89@gmail.com> Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract common logics into SparseMLTrainer so that they could be shared by multiple tasks.