This repository was archived by the owner on Jun 4, 2025. It is now read-only.
[fix] remove image_size from call to rescale_gradient_accumulation #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#200 included a side change to remove the now unused `image_size` arg from the function signature but did not update the call site. this PR fixes that. **test_plan:** Reproduced reported error with a sample quantization recipe and verified this PR resolves it
markurtz
approved these changes
Apr 17, 2023
bfineran
added a commit
that referenced
this pull request
Apr 17, 2023
) #200 included a side change to remove the now unused `image_size` arg from the function signature but did not update the call site. this PR fixes that. **test_plan:** Reproduced reported error with a sample quantization recipe and verified this PR resolves it
bfineran
added a commit
that referenced
this pull request
Apr 17, 2023
) #200 included a side change to remove the now unused `image_size` arg from the function signature but did not update the call site. this PR fixes that. **test_plan:** Reproduced reported error with a sample quantization recipe and verified this PR resolves it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#200 included a side change to remove the now unused
image_sizearg from the function signature but did not update the call site.this PR fixes that.
test_plan:
Reproduced reported error with a sample quantization recipe and verified this PR resolves it