Skip to content

Restore appearance of green reblog symbol in ER#828

Closed
blackjackkent wants to merge 1 commit intonew-xkit:masterfrom
blackjackkent:RestoreGreenReblogInER
Closed

Restore appearance of green reblog symbol in ER#828
blackjackkent wants to merge 1 commit intonew-xkit:masterfrom
blackjackkent:RestoreGreenReblogInER

Conversation

@blackjackkent
Copy link

Resolves #736

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if its an edit, does that work too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or will it just make you look like you've reblogged the post, when you havent?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent point. I will tweak this later.

@blackjackkent
Copy link
Author

Per @nightpool 's comment, need to update this so that it only does the green arrow when the post is a) a reblog and b) being posted. (also verify how this works in vanilla tumblr if queueing/drafting, duplicate if necessary)

@invalidCards
Copy link
Member

@blackjackkent When drafting, queueing or scheduling, the button still turns green in vanilla Tumblr.

@homu
Copy link

homu commented Jan 20, 2016

☔ The latest upstream changes (presumably #832) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ER breaks tumblr green reblogs

5 participants