Inactives language fix

[ChuckL]

Fixed #833

If the user had a different language than English it would fail.

[bvtsang]

We can leave this out.

[nightpool]

would prefer to do peopleCount = parseInt(count_text.replace(etc)) so that the operations are self-documenting

[ChuckL]

@nightpool I think it's fine, it's one logical step per line rather than nested method calls.
I could make another variable to make it easier to read / more documentation if you think that's better.
I could also do something like var count_text = $("#tabs").html().replace(/[^0-9]/g, '')

@bvtsang I opted to have some duplicated code since I think it's easier to read and understand than what I would do probably do otherwise. Make an enum type object and loop through the enums.

[nightpool]

@ChuckL but turning it from the string into the int is a logical operation, right? and that requires dealing both with the useless text and the parseInt function.

I agree with keeping the duplicated code easier to read btw @bvtsang @ChuckL

[ChuckL]

Turning a string to an int in a logical operation.

destroying useless text text then turning it into an interger, in my mind isn't a single logical operation which is shown by the multiple method calls in order to do that.

[nightpool]

down for whatever tbh. its a minor nitpick

On Wed, Dec 9, 2015 at 12:28 AM Charles notifications@github.com wrote:

Turning a string to an int in a logical operation.

destroying useless text text then turning it into an interger, in my mind
isn't a single logical operation.

—
Reply to this email directly or view it on GitHub
#846 (comment).

[ChuckL]

So is this good to go or are there a few bugs / styling stuff still?

[hobinjk]

Tested locally, LGTM. I don't think any of the remaining nitpicks are blockers.
@homu r+

[homu]

📌 Commit ba15e0d has been approved by hobinjk

[homu]

⌛ Testing commit ba15e0d with merge 7ac8167...

[homu]

☀️ Test successful - status