Merged
Conversation
hobinjk
force-pushed
the
glowing-follow-broken
branch
from
3233f8b to
54a9188
Compare
Extensions/glowing_follow.js
Outdated
Member
There was a problem hiding this comment.
Would prefer this to be a new XKit.iframe function. (because I think some blogs still might not have the new controls)
Member
There was a problem hiding this comment.
the selector would be .btn.follow,.tx-button.follow-button then
Improves Glowing Follow's short description. Fixes iframe URL detection for Tumblr update. Updates class used for follow button detection, adding XKit.iframe.follow_button. Fixes new-xkit#844.
hobinjk
force-pushed
the
glowing-follow-broken
branch
from
54a9188 to
5cb778d
Compare
Member
|
doesn't work on blogs with dark backgrounds because it's just varying the opacity. mind filing a followup issue? @homu r+ |
|
📌 Commit 5cb778d has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Dec 24, 2015
Fix issues with Glowing Follow Improves Glowing Follow's short description. Fixes iframe URL detection for Tumblr update. Updates class used for follow button detection. Fixes #844.
Author
|
@nightpool I filed #886 as a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves Glowing Follow's short description. Fixes iframe URL detection
for Tumblr update. Updates class used for follow button detection.
Fixes #844.