Skip to content

Code cleanup and reblog button fix.#887

Merged
homu merged 1 commit intonew-xkit:masterfrom
nepeat:fixreblog
Dec 28, 2015
Merged

Code cleanup and reblog button fix.#887
homu merged 1 commit intonew-xkit:masterfrom
nepeat:fixreblog

Conversation

@nepeat
Copy link

@nepeat nepeat commented Dec 28, 2015

Changes

  • Removed code check for old XKit 7.3.0
  • Removed newlines before/after the braces inside the OCP stylesheets
  • Removed styles that were misspelled or entirely commented out. (bdox-shadow)
  • Replaced the xkit-one-click-reblog-done class with the Tumblr reblogged class.

Before

oh god this is ugly

After

This is better?

Squashed commits
* Use the Tumblr vendor class instead of a custom class.
* Remove the check for XKit versions below 7.3.0.
* Clean up the newlines in the styles.
* Remove misspelled or commented styles.
@nepeat nepeat changed the title [one_click_postages] Code cleanup and reblog button fix. [one_click_postage] Code cleanup and reblog button fix. Dec 28, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks atesh. :/

@nightpool
Copy link
Member

LGTM! @homu r+

@homu
Copy link

homu commented Dec 28, 2015

📌 Commit 3f63a17 has been approved by nightpool

@homu
Copy link

homu commented Dec 28, 2015

⚡ Test exempted - status

@homu homu merged commit 3f63a17 into new-xkit:master Dec 28, 2015
homu added a commit that referenced this pull request Dec 28, 2015
[one_click_postage] Code cleanup and reblog button fix.

# Changes
* Removed code check for old XKit 7.3.0
* Removed newlines before/after the braces inside the OCP stylesheets
* Removed styles that were misspelled or entirely commented out. (`bdox-shadow`)
* Replaced the `xkit-one-click-reblog-done` class with the Tumblr `reblogged` class.

## Before
![oh god this is ugly](https://i.imgur.com/OS6Glpi.png)

## After
![This is better?](https://i.imgur.com/tBXlawT.png)
@nightpool
Copy link
Member

thanks a ton for the contribution--come stop by dev chat more! we miss you

@nightpool nightpool changed the title [one_click_postage] Code cleanup and reblog button fix. Code cleanup and reblog button fix. Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants