Conversation
Extensions/pokes.js
Outdated
There was a problem hiding this comment.
You forgot a semicolon here.
Wolvan
force-pushed
the
features/pokes/implement_pokes_menu_and_list
branch
from
f2bff17 to
b880f83
Compare
|
@ThePsionic that's what I get for coding at 3AM. |
|
|
|
Also, gender icons next to Pokémon on the dashboard are kinda small now |
|
@ThePsionic I don't experience the issues you have, for some reason |
|
Note that I'm using Chrome on Linux Mint. |
|
Never mind, happens in 0.4.1 too. |
|
@ThePsionic good to go then? |
There was a problem hiding this comment.
Not sure what's supposed to show up here, but it doesn't show up.
There was a problem hiding this comment.
The thing is display: none that keeps it from showing up. The icon is supposed to be the edit pen that tumblr uses on posts you can edit if you know what I mean. I did not implement nicknaming yet so I decided to hide the symbol until Nicknames become a thing
Since there are many things planned for Pokes, the interface in the settings panel was not going to be sufficient for it all. The Pokemon list has now been moved into it's own window accessible from a menu in the Pokes settings.
Wolvan
force-pushed
the
features/pokes/implement_pokes_menu_and_list
branch
from
b880f83 to
3bfe384
Compare
|
@ThePsionic I did the fixing magic thingie |
|
LGTM, although I do really think we should use a webfont for the symbols to make sure the same experience is delivered across platforms. |
|
@ThePsionic should we merge this and then decide on a webfont? |
|
They should be very standard symbols—iirc they're even code page 437
|
|
📌 Commit 3bfe384 has been approved by |
|
⚡ Test exempted - status |
…ist, r=ThePsionic Change Pokes interface Since there are many things planned for Pokes, the interface in the settings panel was not going to be sufficient for it all. The Pokemon list has now been moved into it's own window accessible from a menu in the Pokes settings. This brings us a step closer to completing #855 Closes #854
There was a problem hiding this comment.
should be specified in a hex format like the rest of the symbols
There was a problem hiding this comment.
I did not know what the hex format was. I copied it from tumblr's CSS file
6 participants
Since there are many things planned for Pokes, the interface in the
settings panel was not going to be sufficient for it all. The Pokemon
list has now been moved into it's own window accessible from a menu
in the Pokes settings.
This brings us a step closer to completing #855
Closes #854