Adding logic to handle chat posts on viewondash

[blackjackkent]

No associated issue. It's just broken. :P

[nightpool]

I'd prefer to stop supporting view on dash in favor of the new in-dash
viewer. thoughts?

On Mon, Dec 28, 2015 at 8:00 PM BlackjackKent notifications@github.com
wrote:

No associated issue. It's just broken. :P

You can view, comment on, or merge this pull request online at:

#892
Commit Summary

• Adding logic to handle chat posts on viewondash

File Changes

• M Extensions/view_on_dash.js
  https://github.com/new-xkit/XKit/pull/892/files#diff-0 (18)

Patch Links:

• https://github.com/new-xkit/XKit/pull/892.patch
• https://github.com/new-xkit/XKit/pull/892.diff

—
Reply to this email directly or view it on GitHub
#892.

[Wolvan]

@nightpool 👎 Some people have the peeper disabled through open in tabs, they can't use it.
Maybe rewrite view-in-dash to call the peeper though?

[nightpool]

@Wolvan how would open-in-tabs disable the /dashboard/blog/ urls? that
doesn't make any sense.

On Tue, Dec 29, 2015 at 6:29 AM Wolvan notifications@github.com wrote:

@nightpool https://github.com/nightpool [image: 👎] Some people have
the peeper disabled through open in tabs, they can't use it

—
Reply to this email directly or view it on GitHub
#892 (comment).

[Wolvan]

/dashboard/blog/? I thought we were talking about Peepr

[nightpool]

@Wolvan what would you call this
http://tumblr.com/dashboard/blog/new-xkit-extension except peepr?

On Tue, Dec 29, 2015 at 11:21 AM Wolvan notifications@github.com wrote:

/dashboard/blog/? I thought we were talking about Peepr

—
Reply to this email directly or view it on GitHub
#892 (comment).

[Wolvan]

OK, so it is the peepr, it's still rather inaccessible. We could just make view-on-dash, instead of generating the posts ourselves, open the peepr. No need to completely remove View-on-dash

[nightpool]

@Wolvan that's what I meant, sorry.

On Tue, Dec 29, 2015 at 12:47 PM Wolvan notifications@github.com wrote:

OK, so it is the peepr, it's still rather inaccessible. We could just make
view-on-dash, instead of generating the posts ourselves, open the peepr. No
need to completely remove View-on-dash

—
Reply to this email directly or view it on GitHub
#892 (comment).

[Wolvan]

Oh, sorry. In that case, 👍

[hobinjk]

View On Dash's possible replacement by Peepr should be filed as a separate issue. This functionality LGTM.

@homu r+

[homu]

📌 Commit a9e74cd has been approved by hobinjk

[homu]

⌛ Testing commit a9e74cd with merge 745fcb5...

[homu]

☀️ Test successful - status