Skip to content

Add nicknaming and releasing#894

Merged
homu merged 1 commit intonew-xkit:masterfrom
Wolvan:features/pokes/nicknaming_and_release
Dec 31, 2015
Merged

Add nicknaming and releasing#894
homu merged 1 commit intonew-xkit:masterfrom
Wolvan:features/pokes/nicknaming_and_release

Conversation

@Wolvan
Copy link
Member

@Wolvan Wolvan commented Dec 30, 2015

Allow Pokemon to be nicknamed or even released if this is what a user
wants. For this to work properly, storage had to be changed slightly
This also leads to being able to capture multiple Pokemon of a single
species and gender.

Closes 2 points of #855

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(here in the most recent pull)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, I did not know what the unicode is, I copied it from tumblr's stylesheet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Psi, you're a bro. Fixed

Allow Pokemon to be nicknamed or even released if this is what a user
wants. For this to work properly, storage had to be changed slightly
This also leads to being able to capture multiple Pokemon of a single
species and gender
@Wolvan Wolvan force-pushed the features/pokes/nicknaming_and_release branch from dd6a99d to c7a1806 Compare December 31, 2015 12:51
@invalidCards
Copy link
Member

LGTM! Good job @Wolvan
@homu r+

@homu
Copy link

homu commented Dec 31, 2015

📌 Commit c7a1806 has been approved by ThePsionic

@homu
Copy link

homu commented Dec 31, 2015

⚡ Test exempted - status

@homu homu merged commit c7a1806 into new-xkit:master Dec 31, 2015
homu added a commit that referenced this pull request Dec 31, 2015
…ThePsionic

Add nicknaming and releasing

Allow Pokemon to be nicknamed or even released if this is what a user
wants. For this to work properly, storage had to be changed slightly
This also leads to being able to capture multiple Pokemon of a single
species and gender.

Closes 2 points of #855
@Wolvan Wolvan deleted the features/pokes/nicknaming_and_release branch December 31, 2015 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants