Fix xkit control panel to stay on-screen on mobile devices#901
Fix xkit control panel to stay on-screen on mobile devices#901homu merged 9 commits intonew-xkit:masterfrom
Conversation
Pull from upstream
need to make jump to last place happen
|
I don't have an android device to test design with ATM—can you post screenshots? |
|
http://imgur.com/bjXSdlY It's just the old panel, but with div scrolling. The tabs and content divs scroll separately, and the right pane (ext info) is set to be 100% the width of the viewscreen such that you can flick back and forth from the left menu to the settings. The other tabs look like they do in desktop. I want to redo the extension gallery in the future so that each extension doesn't take up so much space, but the html for those is awful and I was going to deal with that when I went to overhaul the html. The weird text wrapping in the settings is also something I couldn't fix without overhauling the html, but I might be overlooking something. If you have any ideas on how to fix it, let me know. |
Extensions/xkit_preferences.js
Outdated
There was a problem hiding this comment.
.title should have position: relative on it to make it behave as an inline label
|
LGTM @homu r+ |
|
📌 Commit 66f4914 has been approved by |
|
⚡ Test exempted - status |
Fix xkit control panel to stay on-screen on mobile devices It's not super-optimized, just some css to make it usable, but we need to rewrite pretty much all the desktop HTML before I'm going to think about optimizing it further.
5 participants
It's not super-optimized, just some css to make it usable, but we need to rewrite pretty much all the desktop HTML before I'm going to think about optimizing it further.