Changed PWA from minimal-ui to standalone, added Help for back/forward navigation in PWA, removed "I think" from comments#126
Merged
gbracha merged 2 commits intonewspeaklanguage:masterfrom Mar 4, 2024
Conversation
page navigation controls (because they only show refresh and back, not forward). Added help section (? button on top) explaining how navigation works in browser, PWA and Electron. Removed the "I think" fro README.md and comments in deployment scripts.
Contributor
Author
|
Gilad, This change request contains PWA navigation changes discussed on Google groups. Details are in the commit. As the change in manifest.json (from minimal-ui to standalone) does not seem to be automatically forced according to the specs (https://w3c.github.io/manifest/#updating), users need to uninstall and reinstall the PWA for the back/forward navigation buttons to not show. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed PWA manifest from minimal-ui to standalone, to hide the explicit page navigation controls (because they only show refresh and back, not forward). Added help section (? button on top) explaining how navigation works in browser, PWA and Electron. Removed the "I think" fro README.md and comments in deployment scripts.