[Step03] 사다리(게임 실행) - #1335
Merged
Merged
Conversation
- Controller 일급 컬렉션 데이터 조회 메서드(getter) 제거 - Line 내부 필드 불변 처리
- Direction enum 으로 변경 - 양방향 연경에 관한 예외 InvalidDirectionException 으로 변경
vagabond95
approved these changes
May 1, 2022
vagabond95
left a comment
vagabond95
left a comment
There was a problem hiding this comment.
이전 단계보다 클래스들의 역할 및 비즈니스 로직이 좀 더 명확해진 것 같습니다 👍
각 도메인이 계단식으로 역할을 잘 수행하고 있어 큰 구조의 변화 없이 잘 구현해주셨네요 ㅎㅎ
크게 피드백 드릴 부분이 없어 3단계도 머지하도록 하겠습니다!
| @@ -0,0 +1,11 @@ | |||
| package ladder.exception; | |||
|
|
|||
| public class InvalidDirectionException extends RuntimeException { | |||
| } | ||
|
|
||
| private ExecutionResults convertExecutionResults() { | ||
| String[] executionResults = readLine().replace(" ", "").split(DEFAULT_DELIMITER); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요! Java CleanCode 14기 박병기 입니다.
사다리게임 미션 완료하여 리뷰 요청 드립니다.
확인 부탁드립니다!
감사힙니다 🙏