[Step04] 사다리(리팩토링) - #1336
Merged
Merged
Conversation
- Direction enum 으로 변경 - white space, blank 변수 사용
- 인스턴스화 방지를 위한 기본 생성자 private 선언
vagabond95
approved these changes
May 2, 2022
vagabond95
left a comment
vagabond95
left a comment
There was a problem hiding this comment.
각 단계 모두 이미 기본이 탄탄하셔서 크게 피드백드릴 부분이 없었기에 빠르게 미션이 마무리되었네요 👍
개인적으로 리뷰어 활동을 하셨어도 될 수준이었다고 생각됩니다!
사다리 미션의 핵심은 복잡한 도메인에 대해 계층구조적인 도메인을 구현하고, 각 도메인이 스스로 일을 처리함으로서 간단한 비즈니스 로직 수준을 유지하는 것이 핵심이었다고 생각됩니다 :)
마지막 미션 마무리까지 화이팅이십니다!
| public boolean isLeft() { | ||
| return isLeft; | ||
| } | ||
| if (isLeft) { |
There was a problem hiding this comment.
enum 을 활용해줌으로써 좀 더 명확한 사용처가 정해지는 것 같네요 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요 TDD 14기 박병기 입니다😃
이전 미션에서 누락되었던 Direction Enum 리팩토링 코드와 ResultConverter 가 유틸성 클래스 형태를 띄고 있어 인스턴스화 방지를 위한 private default constructor 선언하였습니다. 추가적인 개선점이 있다면 말씀 부탁드립니다 🙏
감사합니다! 🙇♂️