Skip to content

chore: add CODEOWNERS so every PR gets a reviewer assigned - #60

Merged
miaulalala merged 2 commits into
mainfrom
chore/codeowners
Sep 2, 2026
Merged

chore: add CODEOWNERS so every PR gets a reviewer assigned#60
miaulalala merged 2 commits into
mainfrom
chore/codeowners

Conversation

@miaulalala

Copy link
Copy Markdown
Collaborator

Nothing currently requests review automatically on this repository, so pull requests from outside sit unnoticed. Right now:

A single fallback owner fixes that.

* @miaulalala

GitHub never requests review from the author of a pull request, so this assigns every PR except my own. That is the intended behaviour rather than a side effect.

Deliberately fallback-only, in the same shape nextcloud/server uses: one broad rule first, with narrower rules added below it as the repository grows more maintainers (the last matching pattern wins).

Note this only requests review. Making it blocking would need "Require review from Code Owners" in the ruleset, which is a separate decision.

AI-Assisted-By: Claude Opus 5 (1M context)

Nothing currently requests review automatically, so PRs from outside the repo
sit unnoticed: two community pull requests (#46, #47) have been open since
31 July, and four Dependabot PRs are open against eight vulnerability alerts.

A single fallback owner fixes that. GitHub does not request review from a PR's
own author, so this assigns every PR except Anna's own, which is the intended
behaviour rather than a side effect.

Deliberately a fallback-only file, in the same shape nextcloud/server uses:
one broad rule first, narrower ones added later as the repository grows more
maintainers. Note this only *requests* review; making it blocking would need
"Require review from Code Owners" in the ruleset, which is a separate decision.

AI-Assisted-By: Claude Opus 5 (1M context)
Signed-off-by: Anna Larch <anna@nextcloud.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is straightforward and functional; only a minor wording inconsistency in a comment was noted.

Pull request overview

Adds a repository-wide CODEOWNERS fallback so every pull request triggers an automatic review request, helping avoid PRs sitting unreviewed.

Changes:

  • Introduces .github/CODEOWNERS with a catch-all rule assigning a default reviewer.
  • Documents intended behavior (author won’t be requested) and how to extend with narrower rules later.
File summaries
File Description
.github/CODEOWNERS Adds a fallback code owner to automatically request reviews on all PRs.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/CODEOWNERS Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Anna <anna@nextcloud.com>
@miaulalala
miaulalala merged commit c993015 into main Sep 2, 2026
1 check passed
@miaulalala
miaulalala deleted the chore/codeowners branch September 2, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants