fix(mail): escape rich-object link when building HTML email subject - #2811
Open
karlitschek wants to merge 1 commit into
Open
fix(mail): escape rich-object link when building HTML email subject#2811karlitschek wants to merge 1 commit into
karlitschek wants to merge 1 commit into
Conversation
The link parameter of rich subject parameters was interpolated into the href attribute of notification and digest emails without escaping, allowing attribute/markup injection into outgoing mail by any activity provider or federated source whose link contains a double quote. Escape the link with htmlspecialchars(ENT_QUOTES), matching the escaping already applied to the link text. Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
ENT_QUOTES is not needed on our supported php versions
|
|
||
| if (isset($parameter['link'])) { | ||
| $replacements[] = '<a href="' . $parameter['link'] . '">' . htmlspecialchars($replacement) . '</a>'; | ||
| $replacements[] = '<a href="' . htmlspecialchars((string)$parameter['link'], ENT_QUOTES) . '">' . htmlspecialchars($replacement) . '</a>'; |
Member
There was a problem hiding this comment.
Suggested change
| $replacements[] = '<a href="' . htmlspecialchars((string)$parameter['link'], ENT_QUOTES) . '">' . htmlspecialchars($replacement) . '</a>'; | |
| $replacements[] = '<a href="' . htmlspecialchars($parameter['link']) . '">' . htmlspecialchars($replacement) . '</a>'; |
|
|
||
| if (isset($parameter['link'])) { | ||
| $replacements[] = '<a href="' . $parameter['link'] . '">' . htmlspecialchars($replacement) . '</a>'; | ||
| $replacements[] = '<a href="' . htmlspecialchars((string)$parameter['link'], ENT_QUOTES) . '">' . htmlspecialchars($replacement) . '</a>'; |
Member
There was a problem hiding this comment.
Suggested change
| $replacements[] = '<a href="' . htmlspecialchars((string)$parameter['link'], ENT_QUOTES) . '">' . htmlspecialchars($replacement) . '</a>'; | |
| $replacements[] = '<a href="' . htmlspecialchars($parameter['link']) . '">' . htmlspecialchars($replacement) . '</a>'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link parameter of rich subject parameters was interpolated into the href attribute of notification and digest emails without escaping, allowing attribute/markup injection into outgoing mail by any activity provider or federated source whose link contains a double quote.
Escape the link with htmlspecialchars(ENT_QUOTES), matching the escaping already applied to the link text.
🤖 AI (if applicable)