Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Oct 16, 2017

This is required for 2.0.0 as we show there (for the very time) our what's new screens during upgrade, and during upgrade we should not delete our accounts ;-)

I have already created a 2.0.0 gplay release with this fix. The tag is still old. I can tag it again after merge of this PR. But as I am tomorrow not really available, I did a 2.0 release manually.

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 2.0.0 milestone Oct 16, 2017
@mario
Copy link
Contributor

mario commented Oct 16, 2017

@tobiasKaminsky did you remember to put google config in + remove the "Your accounts might be corrupted bla bla"? :)

@tobiasKaminsky
Copy link
Member Author

google conf is in.

Account warning is still in, but only enabled for <2.0.0. We can remove this soon.

if (showWarning && version > 10040299 && version < 20000099) {

@mario
Copy link
Contributor

mario commented Oct 16, 2017

👍

Approved with PullApprove

@mario
Copy link
Contributor

mario commented Oct 16, 2017

Thought it's gonna be gone with 2.0, but yea ... :)

@tobiasKaminsky
Copy link
Member Author

No one cared of removing it ;-)
I can do a PR tomorrow. Then we can merge this one and the removal PR and after that I can tag.
But now I am cuddling with Lu <3

@mario
Copy link
Contributor

mario commented Oct 16, 2017

So unprofessional, this cuddling :D But I'll let you get away with it just this once :P

@AndyScherzinger
Copy link
Member

I am on vaca but will be back Wednesday :)
And can do a PR then if that is early enough and it helps me with the Hacktoberfest challenge :)

xXSTrikeXx added a commit to xXSTrikeXx/android that referenced this pull request Oct 16, 2017
as mentioned in nextcloud#1676
Preperation for stable-release.
@enoch85
Copy link
Member

enoch85 commented Oct 17, 2017

I won't press "Update branch" this time, but shouldn't 2.0.0 be released today?

EDIT Yes it is, and I'm super happy it's finally out!

AndyScherzinger pushed a commit to xXSTrikeXx/android that referenced this pull request Oct 18, 2017
as mentioned in nextcloud#1676
Preperation for stable-release.
@AndyScherzinger AndyScherzinger mentioned this pull request Oct 19, 2017
5 tasks
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Oct 19, 2017

👍 fine by me

which one is the removal PR?

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit eb8e0b1 into master Oct 19, 2017
@AndyScherzinger AndyScherzinger deleted the 200wn branch October 19, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants