Skip to content

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Oct 19, 2017

This should fix the account removal on first start of the what's new screen which hasn't made it into 2.0.0 for f-droid (unknown to me if it is in the GPlay version).

It is a cherry pick from the original PR #1676 + the update to the latest gradle plugin (to work) and also sets the version number and code for 2.0.1

cc: @mario for review

The branch is based on the 2.0.0 tag.

Hotfix Release for f-droid

  • Verify that the new version number is shown in settings
  • Verify that logging is disabled
  • Tag new version as stable-2.0.1
  • Verify that it is shown on f-droid (within 24h)
  • Publish APK to https://download.nextcloud.com/android/

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 2.0.1 milestone Oct 19, 2017
@AndyScherzinger AndyScherzinger changed the title Release 2.0.x Release 2.0.1 Oct 19, 2017
@AndyScherzinger
Copy link
Member Author

#1676 (comment) by @tobiasKaminsky mentioned an removal PR is that one missing or did it refer to the "corrupt account RC message"?

@mario
Copy link
Contributor

mario commented Oct 19, 2017

Removing the corrupt accounts thing.

@mario
Copy link
Contributor

mario commented Oct 19, 2017

👍

Approved with PullApprove

@AndyScherzinger
Copy link
Member Author

Tag has been created: https://github.com/nextcloud/android/releases/tag/stable-2.0.1 for f-droid to pick it up. This is a f-droid only release since this issue isn't present on the GPlay release. Bug fixed is #1691 code change is 58db883

pinging @Bubu - Just wanted to let you know that we needed to do a hot fix for Nextcloud's f-droid 2.0.0 release.

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 19, 2017

Due to @tobiasKaminsky being on vacation and this being a needed hotfix 2.0.1 it is released with just 1 review instead of two. I tested the branch/PR and created the tag after testing.

@tobiasKaminsky
Copy link
Member

Yes, I completely forget fdroid when testing/releasing google play version.
Thank you @AndyScherzinger 👍

(note for myself: do not try to work on such things whith a newborn next to you <3)

@mario
Copy link
Contributor

mario commented Oct 20, 2017

That is unfortunate and one of the reasons why we have double reviews, but mistakes do happen, especially when in rush so it's fine. :)

And you've got a sweet new reason for the mistake :D

@AndyScherzinger
Copy link
Member Author

Yeah, no worries, it got reported and fixed!
Just need someone to put a build on the download page on Nextcloud.

@blizzz
Copy link
Member

blizzz commented Oct 20, 2017

Yeah, no worries, it got reported and fixed!

Yup!

Just need someone to put a build on the download page on Nextcloud.

IIRC @rullzer has access to download.nextcloud.com for putting the package there, if this is an issue.

Otherwise, nextcloud.com points directly to F-Droid and to https://download.nextcloud.com/android/, so nothig needs to be done there.

@rullzer
Copy link
Member

rullzer commented Oct 20, 2017

I do. Let me know what needs to be done.

@AndyScherzinger
Copy link
Member Author

@rullzer afaik only @tobiasKaminsky and @LukasReschke can do that since the package needs to be build/signed.

@mario
Copy link
Contributor

mario commented Oct 20, 2017

@AndyScherzinger I can sign the package later and send it to @rullzer .

@AndyScherzinger
Copy link
Member Author

Cool @mario 👍

@xXSTrikeXx
Copy link
Contributor

@tobiasKaminsky I thought you´ve created a roudmap :D
enjoy your vacations ;)

@blizzz
Copy link
Member

blizzz commented Oct 20, 2017

Verify that it is shown on f-droid (within 24h)

After >24h F-Droid still lists only 2.0.0

@AndyScherzinger
Copy link
Member Author

Unfortunately the publishing is done manually by the fdroid folks...

@blizzz
Copy link
Member

blizzz commented Oct 20, 2017

OK, didn't know that.

@AndyScherzinger
Copy link
Member Author

No worries @blizzz - unfortunately that means that it sometimes takes days :/ (still not published...)

@Bubu
Copy link
Contributor

Bubu commented Oct 21, 2017

@blizzz @AndyScherzinger 2.0.1 is build now, but not yet published

@xXSTrikeXx
Copy link
Contributor

just wait until maybe tomorrow ;)

@AndyScherzinger
Copy link
Member Author

@blizzz 2.0.1 went live on F–Droid yesterday:)

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 24, 2017

As we have a new branching system (and I am not yet used to it):
we merge this PR and then have a 2.0.x release branch, from which we can backport hotfixes and release them as 2.0.1, 2.0.2, ...?

👍

Approved with PullApprove

@AndyScherzinger
Copy link
Member Author

Well, in this case, no - We can close this issue.

What imho should have happend but didn't due to limited resources and people being unavailable:

  • create fix targeting master branch
  • merge it to master branch
  • cherry pick fix on my-backport-branch targeting release-2.0.x branch
  • merge it to release-2.0.x branch
  • tag release stable-2.0.1on release-2.0.x branch

What happened this time:

  • create fix targeting master branch (still open)
  • cherry pick fix on release-2.0.x branch and open PR for documentation/discussion
  • tag release stable-2.0.1on release-2.0.x branch

@AndyScherzinger
Copy link
Member Author

So this PR can be closed as soon as someone pusblishes the build on https://download.nextcloud.com/android/ and ticks the last remaining open todo...

Sorry for the confusion...

@tobiasKaminsky
Copy link
Member

I can publish it on download.nc.com. What do we publish there? Google or Fdroid version?

@mario
Copy link
Contributor

mario commented Oct 24, 2017

@tobiasKaminsky it's already there, just not GPG signed (unless it was done by Lukas later). I actually built a generic version for the download.nc.com.

@AndyScherzinger
Copy link
Member Author

To answer your question @tobiasKaminsky I think F-Droid :) As for the signing... no idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants