-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Release 2.0.1 #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.1 #1696
Conversation
Signed-off-by: Mario Danic <mario@lovelyhq.com>
|
#1676 (comment) by @tobiasKaminsky mentioned an removal PR is that one missing or did it refer to the "corrupt account RC message"? |
|
Removing the corrupt accounts thing. |
|
Tag has been created: https://github.com/nextcloud/android/releases/tag/stable-2.0.1 for f-droid to pick it up. This is a f-droid only release since this issue isn't present on the GPlay release. Bug fixed is #1691 code change is 58db883 pinging @Bubu - Just wanted to let you know that we needed to do a hot fix for Nextcloud's f-droid 2.0.0 release. |
|
Due to @tobiasKaminsky being on vacation and this being a needed hotfix 2.0.1 it is released with just 1 review instead of two. I tested the branch/PR and created the tag after testing. |
|
Yes, I completely forget fdroid when testing/releasing google play version. (note for myself: do not try to work on such things whith a newborn next to you <3) |
|
That is unfortunate and one of the reasons why we have double reviews, but mistakes do happen, especially when in rush so it's fine. :) And you've got a sweet new reason for the mistake :D |
|
Yeah, no worries, it got reported and fixed! |
Yup!
IIRC @rullzer has access to download.nextcloud.com for putting the package there, if this is an issue. Otherwise, nextcloud.com points directly to F-Droid and to https://download.nextcloud.com/android/, so nothig needs to be done there. |
|
I do. Let me know what needs to be done. |
|
@rullzer afaik only @tobiasKaminsky and @LukasReschke can do that since the package needs to be build/signed. |
|
@AndyScherzinger I can sign the package later and send it to @rullzer . |
|
Cool @mario 👍 |
|
@tobiasKaminsky I thought you´ve created a roudmap :D |
After >24h F-Droid still lists only 2.0.0 |
|
Unfortunately the publishing is done manually by the fdroid folks... |
|
OK, didn't know that. |
|
No worries @blizzz - unfortunately that means that it sometimes takes days :/ (still not published...) |
|
@blizzz @AndyScherzinger 2.0.1 is build now, but not yet published |
|
just wait until maybe tomorrow ;) |
|
@blizzz 2.0.1 went live on F–Droid yesterday:) |
|
Well, in this case, no - We can close this issue. What imho should have happend but didn't due to limited resources and people being unavailable:
What happened this time:
|
|
So this PR can be closed as soon as someone pusblishes the build on https://download.nextcloud.com/android/ and ticks the last remaining open todo... Sorry for the confusion... |
|
I can publish it on download.nc.com. What do we publish there? Google or Fdroid version? |
|
@tobiasKaminsky it's already there, just not GPG signed (unless it was done by Lukas later). I actually built a generic version for the download.nc.com. |
|
To answer your question @tobiasKaminsky I think F-Droid :) As for the signing... no idea. |
This should fix the account removal on first start of the what's new screen which hasn't made it into 2.0.0 for f-droid (unknown to me if it is in the GPlay version).
It is a cherry pick from the original PR #1676 + the update to the latest gradle plugin (to work) and also sets the version number and code for 2.0.1
cc: @mario for review
The branch is based on the 2.0.0 tag.
Hotfix Release for f-droid
stable-2.0.1