Skip to content

fix(conflict-resolve): thumbnail generation - #17424

Open
alperozturk96 wants to merge 2 commits into
masterfrom
fix/thumbnail-generation-conflict-resolve
Open

fix(conflict-resolve): thumbnail generation#17424
alperozturk96 wants to merge 2 commits into
masterfrom
fix/thumbnail-generation-conflict-resolve

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Uses MediaThumbnailGenerationTask
  • onStop replaced with onDestroyView

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.1 milestone Aug 4, 2026
@alperozturk96

alperozturk96 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.1.x

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/30905344083/artifacts/8891806199
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17424-IT-master-12-29

@alperozturk96
wip
ff37fc5 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
0d98a14 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/thumbnail-generation-conflict-resolve branch from 5675ae3 to 0d98a14 Compare August 6, 2026 06:25
@alperozturk96 alperozturk96 linked an issue Aug 6, 2026 that may be closed by this pull request
No way to confidently know .... #17242
Open
4 tasks
@alperozturk96 alperozturk96 mentioned this pull request Aug 6, 2026
Open
4 tasks
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/31077232453/artifacts/8958140929
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6464
Dodgy code216216
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4040
Security1919
Total399399

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

Nextcloud App 34.1.1

Development

Successfully merging this pull request may close these issues.

No way to confidently know ....

1 participant

@alperozturk96