transifex -> fastlane converter#1752
Conversation
|
As nextcloud/docker-ci#62 was merged, we need to merge this also, otherwise all transifex updates will fail. |
1a99418 to
00c1fec
Compare
| <issue id="UnusedResources"> | ||
| <ignore regexp="store_short_desc|store_full_desc" /> | ||
| </issue> | ||
| </lint> No newline at end of file |
| XML_PATH = '../../src/main/res' | ||
| METADATA_PATH = '../../fastlane/metadata/android' | ||
| DEFAULT_LANG = 'en-US' | ||
| LANG_MAP = { |
There was a problem hiding this comment.
Can we generate this dynamically?
There was a problem hiding this comment.
If you do, make sure you make a pull request to this file upstream ;)
There was a problem hiding this comment.
Makes sense. Just take the special mapping from .tx/config and then use normal mapping like for "'values-zh-rKN': 'zh-HK'," do
- drop
values- - replace
-rwith-
Done ;)
There was a problem hiding this comment.
I doubt that it is that easy.
For example in .txc.conf is id_ID: id-rID which is in our project only "values-id".
German is "values-de" and "values-de-rDE", and not translated to "rCH", "rAT".
So for switzerland (ch) values-de is used. Of course we can add "values-de-rCH", but this would double the work and I guess it is the same content...
There was a problem hiding this comment.
Need to agree with @tobiasKaminsky - unfortunately the codes do different on the different plattforms :/
There was a problem hiding this comment.
We can try to enhance this and discuss it on a new issue if you want.
But for now (and to get master building again) I would like to merge this as it is.
as figured out with @MorrisJobke georgian language does not have different quantities. |
|
Seems to be a transifex issue since Georgian has the translations for one and other for the strings but then it seems that transifex doesn't export them?! I tried to replace it but as soon as I set the "one" value is is shown for other too and during export it will only be exported as other. |
|
As Georgian language only has one case, it indeed seems fine/sane for me to use "other", as as this will be used if no other case will hold. So it is fine that transifex only needs and exports "other". |
|
Build turned green now and new line is fixed @mario so you might take another look :) |
|
And here it is: d4b7d26 😉 |
Thanks to @grote (fastlane/fastlane#9520 (comment))
This allows us to have full/short description on transifex in only one resource.
With @MorrisJobke I will intregrate this to our daily transifex job, so it will get updated each day.