Skip to content

transifex -> fastlane converter#1752

Merged
AndyScherzinger merged 6 commits intomasterfrom
transifexFastlane
Nov 8, 2017
Merged

transifex -> fastlane converter#1752
AndyScherzinger merged 6 commits intomasterfrom
transifexFastlane

Conversation

@tobiasKaminsky
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky commented Nov 6, 2017

Thanks to @grote (fastlane/fastlane#9520 (comment))

This allows us to have full/short description on transifex in only one resource.
With @MorrisJobke I will intregrate this to our daily transifex job, so it will get updated each day.

  • move translated strings from transifex android app store listing to android, only possible once this is merged

@AndyScherzinger
Copy link
Copy Markdown
Member

AndyScherzinger commented Nov 6, 2017

👍

Approved with PullApprove

@tobiasKaminsky
Copy link
Copy Markdown
Member Author

As nextcloud/docker-ci#62 was merged, we need to merge this also, otherwise all transifex updates will fail.

mario
mario previously requested changes Nov 7, 2017
Comment thread lint.xml Outdated
<issue id="UnusedResources">
<ignore regexp="store_short_desc|store_full_desc" />
</issue>
</lint> No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line.

XML_PATH = '../../src/main/res'
METADATA_PATH = '../../fastlane/metadata/android'
DEFAULT_LANG = 'en-US'
LANG_MAP = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generate this dynamically?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do, make sure you make a pull request to this file upstream ;)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Just take the special mapping from .tx/config and then use normal mapping like for "'values-zh-rKN': 'zh-HK'," do

  • drop values-
  • replace -r with -

Done ;)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that it is that easy.
For example in .txc.conf is id_ID: id-rID which is in our project only "values-id".
German is "values-de" and "values-de-rDE", and not translated to "rCH", "rAT".
So for switzerland (ch) values-de is used. Of course we can add "values-de-rCH", but this would double the work and I guess it is the same content...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to agree with @tobiasKaminsky - unfortunately the codes do different on the different plattforms :/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to enhance this and discuss it on a new issue if you want.
But for now (and to get master building again) I would like to merge this as it is.

@tobiasKaminsky
Copy link
Copy Markdown
Member Author

../../../src/main/res/values-ka-rGE/strings.xml:191: For locale "ka" (Georgian) the following quantities should also be defined: one

as figured out with @MorrisJobke georgian language does not have different quantities.
Changing it from "other" to "one" works locally.
But I have no clue how to do this on transifex...

@AndyScherzinger
Copy link
Copy Markdown
Member

Seems to be a transifex issue since Georgian has the translations for one and other for the strings but then it seems that transifex doesn't export them?! I tried to replace it but as soon as I set the "one" value is is shown for other too and during export it will only be exported as other.

@tobiasKaminsky
Copy link
Copy Markdown
Member Author

As Georgian language only has one case, it indeed seems fine/sane for me to use "other", as as this will be used if no other case will hold. So it is fine that transifex only needs and exports "other".
Strange is then, that lint/android studio wants to have also "one".
As a hotfix I set lint to ignore missing quantity errors on Georgian language.

@AndyScherzinger
Copy link
Copy Markdown
Member

Build turned green now and new line is fixed @mario so you might take another look :)

@mario
Copy link
Copy Markdown
Contributor

mario commented Nov 8, 2017

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger dismissed mario’s stale review November 8, 2017 08:43

See last approval

@AndyScherzinger AndyScherzinger merged commit 30b650c into master Nov 8, 2017
@AndyScherzinger AndyScherzinger deleted the transifexFastlane branch November 8, 2017 08:43
@AndyScherzinger AndyScherzinger modified the milestone: Nextcloud App 2.1.0 Nov 8, 2017
@MorrisJobke
Copy link
Copy Markdown
Member

And here it is: d4b7d26 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants