Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 6, 2019

Bumps appcompat from 1.0.2 to 1.1.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @ezaquarii.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Sep 6, 2019
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.1.0 branch 2 times, most recently from abf2aa7 to 8458ef6 Compare September 9, 2019 10:52
@AndyScherzinger
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.1.0 branch from 8458ef6 to 6ebeac3 Compare September 10, 2019 07:02
@tobiasKaminsky
Copy link
Member

@ezaquarii I added a fix: dc76015

It seems that the parameters are no longer nullable.
Is this correct?

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

dependabot-preview bot and others added 2 commits September 16, 2019 20:03
Bumps appcompat from 1.0.2 to 1.1.0.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger AndyScherzinger force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.1.0 branch from dc76015 to e2bc773 Compare September 16, 2019 18:05
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #4473 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4473      +/-   ##
============================================
- Coverage     16.98%   16.96%   -0.02%     
  Complexity        3        3              
============================================
  Files           364      364              
  Lines         32085    32088       +3     
  Branches       4517     4518       +1     
============================================
- Hits           5449     5445       -4     
- Misses        25742    25748       +6     
- Partials        894      895       +1
Impacted Files Coverage Δ Complexity Δ
...xtcloud/client/etm/pages/EtmPreferencesFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/ui/activity/ShareActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../nextcloud/client/onboarding/FirstRunActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../android/authentication/AuthenticatorActivity.java 1.85% <0%> (-0.01%) 0 <0> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 35.03% <0%> (-0.55%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 29.44% <0%> (-0.2%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 19.64% <0%> (-0.08%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (+1.19%) 0% <0%> (ø) ⬇️

@nextcloud-android-bot
Copy link
Collaborator

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10937.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

277

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings141
Total429

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings141
Total429

@dependabot-preview
Copy link
Contributor Author

Dependabot tried to merge this PR, but received the following error from GitHub:

You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information.

@AndyScherzinger
Copy link
Member

@ezaquarii fancy taking a look/review?

@tobiasKaminsky added a fix: e2bc773
and so did I: fc86b57 (to fix the new lint errors)

@AndyScherzinger
Copy link
Member

@ezaquarii fancy taking a look/review?

@AndyScherzinger AndyScherzinger merged commit 7c1aae4 into master Sep 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the dependabot/gradle/androidx.appcompat-appcompat-1.1.0 branch September 23, 2019 21:24
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.9.0 milestone Sep 23, 2019
tobiasKaminsky added a commit that referenced this pull request Sep 24, 2019
7c1aae4 Merge pull request #4473 from nextcloud/dependabot/gradle/androidx.appcompat-appcompat-1.1.0
9f6edd7 Merge pull request #4541 from nextcloud/dependabot/gradle/com.google.android-flexbox-1.1.1
61d3643 Bump flexbox from 1.1.0 to 1.1.1
8429ba3 [tx-robot] updated from transifex
a2d826e [tx-robot] updated from transifex
2b948f5 daily dev 20190921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants