fix dark theme preference for dev version: use different preference name

[tobiasKaminsky]

Fix #4997

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12003.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

328

Lint

Type	master	PR
Warnings	73	73
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409

[codecov]

Codecov Report

Merging #5012 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5012      +/-   ##
============================================
+ Coverage     17.64%   17.68%   +0.03%     
  Complexity        3        3              
============================================
  Files           385      385              
  Lines         32679    32679              
  Branches       4594     4594              
============================================
+ Hits           5767     5778      +11     
+ Misses        25988    25978      -10     
+ Partials        924      923       -1

Impacted Files	Coverage Δ	Complexity Δ
...owncloud/android/ui/activity/SettingsActivity.java	39.38% <100%> (ø)	0 <0> (ø)	⬇️
...cloud/android/ui/activity/FileDisplayActivity.java	20.52% <0%> (+0.24%)	0% <0%> (ø)	⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java	25.73% <0%> (+0.84%)	0% <0%> (ø)	⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java	26.81% <0%> (+1%)	0% <0%> (ø)	⬇️
.../third_parties/daveKoeller/AlphanumComparator.java	83.33% <0%> (+1.19%)	0% <0%> (ø)	⬇️
...om/owncloud/android/utils/FileSortOrderByName.java	17.14% <0%> (+2.85%)	0% <0%> (ø)	⬇️

[AndyScherzinger]

@tobiasKaminsky I might be wrong here, but this changes the preference name for any build, not just the dev build, right?So I am not sure how this fixes the issue.

[tobiasKaminsky]

Previous setting was boolean, but now we have a string/enum.
As this will cause a typecast exception (which we cannot really handle, as it is internally in Android), I chose to just have a new setting/name.

You are right, that this will also remove the existing value of latest official version.
But I guess this is not that bad, as then users will go to settings and can use the third option, if available.

[AndyScherzinger]

@tobiasKaminsky broken, uses 2 different keys now! see call
https://github.com/nextcloud/android/blob/master/src/main/java/com/owncloud/android/ui/activity/SettingsActivity.java#L720