Opt-out of scoped storage #5014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashpieboop
added
3. to review
needs info
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
ashpieboop
force-pushed
the
android-10-scoped-storage-workaround
branch
from
f46f15e to
1919a66
Compare
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12008.apk |
Collaborator
Codacy328Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #5014 +/- ##
===========================================
+ Coverage 17.57% 17.68% +0.1%
Complexity 3 3
===========================================
Files 385 385
Lines 32679 32679
Branches 4594 4594
===========================================
+ Hits 5743 5778 +35
+ Misses 26009 25970 -39
- Partials 927 931 +4
|
Member
I did not had the time to look into scoped storages… |
tobiasKaminsky
approved these changes
Dec 16, 2019
AndyScherzinger
approved these changes
Dec 16, 2019
delete-merged-branch
bot
deleted the
android-10-scoped-storage-workaround
branch
AndyScherzinger
removed
the
needs info
tobiasKaminsky
added a commit
that referenced
this pull request
Dec 17, 2019
8daa9a2 Merge pull request #5014 from nextcloud/android-10-scoped-storage-workaround 1919a66 Opt-out of scoped storage 1656f64 Merge pull request #5012 from nextcloud/darkThemePref 74ab9a0 Merge pull request #5013 from nextcloud/addLibCommit 0ad5785 add library commit hash for reproducable builds b065e9b fix dark theme preference for dev version: use different preference name 14a7493 [tx-robot] updated from transifex a6eb5dd [tx-robot] updated from transifex 669b269 daily dev 20191214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix denied access (throwing FileNotFoundExceptions) to "out of scoped storage" files.
https://developer.android.com/training/data-storage/compatibility
The Nextcloud android app needs to access any external storage in the case of a custom folder sync or external media file folders.
While I named the branch "-workaround", it looks like the app will never use scoped storage unless it implements some on-demand by path access permission (correct me if I'm wrong).