prevent NPE #5172
Merged
prevent NPE #5172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable-3.10 |
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12251-IT |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
preventNPE
branch
from
9264a25 to
f8c9af4
Compare
AndyScherzinger
approved these changes
Jan 13, 2020
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12255.apk |
Collaborator
Codacy340Lint
SpotBugs (new)
SpotBugs (master)
|
|
backport to stable-3.10 in #5185 |
tobiasKaminsky
added a commit
that referenced
this pull request
Jan 15, 2020
6f86e49 Merge pull request #5193 from nextcloud/uploadInReadonlyFolder 5ddc5a8 Merge pull request #5189 from nextcloud/removeLines 2011f52 Merge pull request #5157 from nextcloud/ezaquarii/fix-npe-in-get-user-in-user-account-manager 4cb800e Merge pull request #5187 from nextcloud/fab 447cac9 Upload button: disable/grey when folder is read-only 8b7d39c dark background to #151515 minor design changes for dark theme 7ba3bf0 FAB: show disabled correctly again f68e9e0 Merge pull request #5181 from nextcloud/vCard30 a8f4161 Merge pull request #5172 from nextcloud/preventNPE b2a1245 Merge pull request #5175 from nextcloud/rwEnhancements e2c3613 [tx-robot] updated from transifex 09183fe export vCard to 3.0 version f8c9af4 simplify if statement 33b0861 prevent NPE f01cdd6 UI enhancements to rich workspaces b1f198f [tx-robot] updated from transifex a428738 [tx-robot] updated from transifex 09d98e1 daily dev 20200112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to google dev console there were many crashes.
So this should prevent it, though I do not know which and why something is null there.
It must be either menuItem or mFile, but both should be not null…
Fixes #5168
Fixes #5166
Fixes #5161
Fixes #5159
Fixes #5173
Signed-off-by: tobiasKaminsky tobias@kaminsky.me