Upload button: disable/grey when folder is read-only

[tobiasKaminsky]

Fix #5190

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[tobiasKaminsky]

/backport to stable-3.10

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12277.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

340

Lint

Type	master	PR
Warnings	76	76
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	71
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	107
Security Warnings	44
Dodgy code Warnings	138
Total	413

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	71
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	107
Security Warnings	44
Dodgy code Warnings	139
Total	414

[codecov]

Codecov Report

Merging #5193 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #5193      +/-   ##
============================================
- Coverage     17.64%   17.61%   -0.03%     
  Complexity        3        3              
============================================
  Files           392      392              
  Lines         33137    33140       +3     
  Branches       4656     4656              
============================================
- Hits           5846     5839       -7     
- Misses        26342    26343       +1     
- Partials        949      958       +9

Impacted Files	Coverage Δ	Complexity Δ
...roid/ui/activity/ReceiveExternalFilesActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java	65.92% <0%> (-1.77%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	31.75% <0%> (-0.55%)	0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java	58.94% <0%> (-0.41%)	0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java	24.9% <0%> (-0.4%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	28% <0%> (-0.18%)	0% <0%> (ø)
...rc/main/java/com/nextcloud/java/util/Optional.java	17.3% <0%> (ø)	0% <0%> (ø)	⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java	26.31% <0%> (ø)	0% <0%> (ø)	⬇️
...loud/android/ui/fragment/ExtendedListFragment.java	53.03% <0%> (+0.57%)	0% <0%> (ø)	⬇️
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (+1.19%)	0% <0%> (ø)	⬇️

[backportbot-nextcloud]

backport to stable-3.10 in #5197