Update dependencies and workflows and update version to 35#440
Merged
Conversation
marcelklehr
reviewed
Jul 21, 2026
| "optimize-autoloader": true, | ||
| "classmap-authoritative": true, | ||
| "platform": { | ||
| "php": "8.2" |
Member
There was a problem hiding this comment.
Mmh, not sure if this is wise. If we keep nc 33 support, we should stay on the lowest possible php version here, I think, but then nc 35 doesn't run anymore, I guess, which is why you bumped the version here … Maybe let's drop nc < 35?
Member
Author
There was a problem hiding this comment.
Supposedly all versions from nc 28 to nc 35 support php 8.3 (https://github.com/nextcloud/server/wiki/Releases-and-PHP-versions), I bumped it like you said though because of nc 35
Member
There was a problem hiding this comment.
Dependencies are resolved against platform.php, though, so this change might cause dependencies to become incompatible with php 8.2 -- this app doesn't have any composer deps though, it seems, so should be fine 👍
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
update-dependencies
branch
from
July 21, 2026 14:00
1947248 to
c132a82
Compare
marcelklehr
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)