Audio translation#601
Merged
Merged
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…s of the audio translation provider Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
5307384 to
a71e365
Compare
lukasdotcom
reviewed
Jul 8, 2026
lukasdotcom
left a comment
Member
There was a problem hiding this comment.
Didn't test this, but looks fine.
…pendencies, run cs:fix Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
a71e365 to
8941f14
Compare
marcelklehr
reviewed
Jul 9, 2026
| // $context->registerTaskProcessingTaskType(ImageToTextTranslateTaskType::class); | ||
| // $context->registerTaskProcessingProvider(ImageToTextTranslateProvider::class); | ||
|
|
||
| $context->registerTaskProcessingProvider(AudioToAudioTranslateProvider::class); |
Member
There was a problem hiding this comment.
Should we only register this if all subordinate task types have a provider available? Otherwise getPreferredTaskType throws
Member
Author
There was a problem hiding this comment.
I tried
$availableTaskTypeIds = $this->taskProcessingManager->getAvailableTaskTypeIds();
if (in_array(AudioToText::ID, $availableTaskTypeIds, true)) {
$context->registerTaskProcessingProvider(AudioToAudioTranslateProvider::class);
}but at this point not all the task types are registered, on my setup I only get core:audio2audio:chat and assistant:text2sticker. Not sure if we can really check what's available here.
marcelklehr
reviewed
Jul 9, 2026
marcelklehr
reviewed
Jul 9, 2026
marcelklehr
reviewed
Jul 9, 2026
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
marcelklehr
reviewed
Jul 9, 2026
… AudioToAudioTranslateProvider Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
marcelklehr
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)