feat: refresh user mounts when removed from a group or circle that has associated team folders#2615
Draft
cristianscheid wants to merge 1 commit into
Draft
Conversation
2b0312a to
a111729
Compare
Member
Author
|
Converted to draft to wait for nextcloud/groupfolders#4884 to be merged first. |
7 tasks
miaulalala
reviewed
Jul 13, 2026
…s associated team folders Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
a111729 to
2dac9da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a team folder is shared with a group or circle, removing a member currently leaves a stale entry for that folder in
oc_mountsuntil their next login.This PR refreshes the user's mounts (removing the stale entry) upon detecting the following events:
OCP\Group\Events\UserRemovedEventOCA\Circles\Events\CircleMemberRemovedEventTo avoid refreshing mounts unnecessarily, the refresh only runs if the group/circle actually has a team folder associated with it.
The refresh logic mirrors what the
files:mount:refreshcommand already does:https://github.com/nextcloud/server/blob/master/apps/files/lib/Command/Mount/Refresh.php#L45
This PR depends on the following PR being merged first, which introduces methods to check whether a given group or circle has a team folder shared with it:
Checklist
3. to review, feature component)stable32)AI (if applicable)