fix(circles): preserve group display names when creating circles - #2722
Merged
Conversation
Related to nextcloud/collectives#1510 Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the display name of group-backed circles being initialized with the internal group ID instead of the group’s display name.
Related to nextcloud/collectives#1510
Root cause:
When a local group circle is created,
FederatedUserService::getGroupCircle()already loads the corresponding group but initializes the circle with:Notes:
cached_name. Best as I can tell, existing records should (eventually) be repaired by Circles’ synchronization or a migration/maintenance tasks.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)