Skip to content

fix(circles): preserve group display names when creating circles - #2722

Merged
mejo- merged 1 commit into
masterfrom
jtr/fix-displayName-vs-GrID
Aug 5, 2026
Merged

fix(circles): preserve group display names when creating circles#2722
mejo- merged 1 commit into
masterfrom
jtr/fix-displayName-vs-GrID

Conversation

@joshtrichards

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Fixes the display name of group-backed circles being initialized with the internal group ID instead of the group’s display name.

Related to nextcloud/collectives#1510

Root cause:

When a local group circle is created, FederatedUserService::getGroupCircle() already loads the corresponding group but initializes the circle with:

$circle->setDisplayName($groupId);

Notes:

  • This fix corrects newly created group circles, but existing Circles records may still have the group ID in cached_name. Best as I can tell, existing records should (eventually) be repaired by Circles’ synchronization or a migration/maintenance tasks.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Related to nextcloud/collectives#1510

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable34

@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable33

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mejo-
mejo- merged commit 437814e into master Aug 5, 2026
44 checks passed
@mejo-
mejo- deleted the jtr/fix-displayName-vs-GrID branch August 5, 2026 10:23
@nextcloud nextcloud deleted a comment from backportbot Bot Aug 5, 2026
@nextcloud nextcloud deleted a comment from backportbot Bot Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants