Skip to content

Design pass and team pages - #2846

Merged
artonge merged 22 commits into
masterfrom
vertical-navigation
Sep 2, 2026
Merged

Design pass and team pages#2846
artonge merged 22 commits into
masterfrom
vertical-navigation

Conversation

@marcoambrosini

@marcoambrosini marcoambrosini commented Aug 28, 2026

Copy link
Copy Markdown
Member

Re-organize the existing features, polishing and add a new team pages feature.

Screenshot 2026-08-28 at 17 23 16 Screenshot 2026-08-28 at 17 23 34 Screenshot 2026-08-28 at 17 23 45

@marcoambrosini
marcoambrosini requested a review from artonge August 28, 2026 15:39
@github-project-automation github-project-automation Bot moved this to Backlog in 👥 Teams Aug 28, 2026
@marcoambrosini marcoambrosini moved this from Backlog to In review in 👥 Teams Aug 28, 2026
@marcoambrosini marcoambrosini self-assigned this Aug 28, 2026
@alimmroth alimmroth added this to the Nextcloud 35 milestone Aug 28, 2026

@artonge artonge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall, still some comments.
I also would like to the opinion of a frontender before merging.

Comment thread lib/Controller/TeamTabsController.php
Comment thread LICENSES/LicenseRef-NextcloudTrademarks.txt Outdated
Comment thread src/teams/components/TeamAvatar.vue Outdated
Comment thread vite.config.ts
Comment thread REUSE.toml Outdated
Comment thread src/teams/api.ts Outdated
Comment thread src/teams/api.ts Outdated
Comment thread src/teams/api.ts
Comment thread src/teams/views/PageView.vue Outdated
Comment thread src/teams/views/PageView.vue Outdated
Comment thread src/teams/resourcesStore.ts Outdated
Comment thread src/teams/views/TeamHomeView.vue Outdated
Comment thread src/teams/components/TeamNavigation.vue
Comment thread src/teams/api.ts Outdated
@pringelmann

pringelmann commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Really nice work, this is a big step up from what we had!

One process thing, not a blocker: this is quite a lot to review all at once. ~3.5k new lines over 40+ files with major changes covering four different code sites.

Not asking you to split it now, that rebase would be miserable. But maybe next time start with something more self-contained like the tab ordering (new controller, new route, one store field). This is easier for everyone as a standalone PR to review.

Github also just made it simpler to stack your PRs so you aren't blocked by reviews:
https://github.github.com/gh-stack/
https://docs.github.com/en/pull-requests/how-tos/stacked-pull-requests

@pringelmann pringelmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking comments

Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.55056% with 72 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/teams/api.ts 2.17% 45 Missing ⚠️
src/teams/resourcesStore.ts 73.49% 19 Missing and 3 partials ⚠️
src/teams/composables/useTeamActions.ts 50.00% 3 Missing ⚠️
src/teams/views/TeamFolderView.vue 93.75% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Comment thread src/teams/router.ts Outdated
Comment thread src/teams/api.ts Outdated
Comment thread LICENSES/LicenseRef-NextcloudTrademarks.txt
Marco Ambrosini added 2 commits September 2, 2026 12:50
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Marco Ambrosini added 17 commits September 2, 2026 12:50
The avatar endpoint already serves 24h cache headers; a per-circle
version busts them after an update. No CSRF check on the endpoint so
plain image elements can load it, as Talk does for conversations.

Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Port of the shortcut from the legacy details page: deck's endpoint
links the board to the team, no separate share step needed.

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Deck boards attached to the team itself (deck's teamId) become tabs;
boards merely shared to the team stay in the shared-with-team view.
Deck's board list omits teamId, so each deck resource is read
individually to tell the two apart.

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
The collective and board entries show their app's own icon (inlined,
theme-colored); route entries switch to the filled icon variant while
active.

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
The team's own URL forwards to the first entry of the saved tab order
once it is known, instead of hardcoding the folder tab.

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
@artonge

artonge commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Psalm issue is not related, merging

@artonge
artonge merged commit b0c872e into master Sep 2, 2026
48 of 49 checks passed
@artonge
artonge deleted the vertical-navigation branch September 2, 2026 14:16
@github-project-automation github-project-automation Bot moved this from In review to Done in 👥 Teams Sep 2, 2026
@artonge

artonge commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

@artonge

artonge commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

@backportbot

backportbot Bot commented Sep 2, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/2846/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f473549b a991c62a 6f559a10 45912079 bf88f39c 98cdd0b2 680fc48b e3458000 3c8ba4b3 6a1d3d69 8301b93f a1fb83e9 43b12294 231f4d07 1db82d14 00433d96 fbc80f90 1a7173bb 9fa55760 562bebdf c4dc3af0 c8e4e5d8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2846/stable35

Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401
fatal: expected flush after ref listing


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants