Design pass and team pages - #2846
Conversation
d1a2ffa to
88ae97e
Compare
artonge
left a comment
There was a problem hiding this comment.
Good overall, still some comments.
I also would like to the opinion of a frontender before merging.
20e1b7c to
88ae97e
Compare
|
Really nice work, this is a big step up from what we had! One process thing, not a blocker: this is quite a lot to review all at once. ~3.5k new lines over 40+ files with major changes covering four different code sites. Not asking you to split it now, that rebase would be miserable. But maybe next time start with something more self-contained like the tab ordering (new controller, new route, one store field). This is easier for everyone as a standalone PR to review. Github also just made it simpler to stack your PRs so you aren't blocked by reviews: |
pringelmann
left a comment
There was a problem hiding this comment.
No blocking comments
88ae97e to
73fac59
Compare
73fac59 to
3dd2110
Compare
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
3dd2110 to
27d126a
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
27d126a to
56b3afc
Compare
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
The avatar endpoint already serves 24h cache headers; a per-circle version busts them after an update. No CSRF check on the endpoint so plain image elements can load it, as Talk does for conversations. Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com> Assisted-by: ClaudeCode:claude-fable-5
Port of the shortcut from the legacy details page: deck's endpoint links the board to the team, no separate share step needed. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Deck boards attached to the team itself (deck's teamId) become tabs; boards merely shared to the team stay in the shared-with-team view. Deck's board list omits teamId, so each deck resource is read individually to tell the two apart. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
The collective and board entries show their app's own icon (inlined, theme-colored); route entries switch to the filled icon variant while active. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
The team's own URL forwards to the first entry of the saved tab order once it is known, instead of hardcoding the folder tab. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marco Ambrosini <marco.ambrosini@nextcloud.com>
56b3afc to
c8e4e5d
Compare
|
Psalm issue is not related, merging |
|
/backport to stable35 |
|
/backport to stable35 |
|
The backport to # Switch to the target branch and update it
git checkout stable35
git pull origin stable35
# Create the new backport branch
git checkout -b backport/2846/stable35
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f473549b a991c62a 6f559a10 45912079 bf88f39c 98cdd0b2 680fc48b e3458000 3c8ba4b3 6a1d3d69 8301b93f a1fb83e9 43b12294 231f4d07 1db82d14 00433d96 fbc80f90 1a7173bb 9fa55760 562bebdf c4dc3af0 c8e4e5d8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2846/stable35Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401 Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Re-organize the existing features, polishing and add a new team pages feature.