Add shareable comparison links - #2700
Draft
hweihwang wants to merge 2 commits into
Draft
Conversation
hweihwang
force-pushed
the
review/collectives-version-comparison-routing
branch
from
August 14, 2026 18:24
5cbd872 to
a964840
Compare
Namespace current and historical canonical identities, retain rollover aliases, quarantine genuine duplicates, and preserve unrelated route state. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Restore comparison pairs from URLs, keep history and slug updates scoped, report invalid or unavailable identities, and copy only successful pinned links. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
review/collectives-version-comparison-routing
branch
from
August 17, 2026 15:27
a964840 to
2c826e0
Compare
benjaminfrueh
self-requested a review
August 18, 2026 07:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comparison you cannot link to cannot be discussed with others. And a link that silently follows later edits is worse than no link: after the page changes, the same URL shows a different comparison without any warning. This PR pins comparison URLs to exact revision identities, so a shared link always shows what was shared.
What's in this PR
compareFrom/compareToURL parameters pin two exact revisions. The pair survives reload, Back, Forward, copy into another session, and page rename.current:<id>/version:<id>). Aliases keep previously shared links resolving.The pinned identity is never silently replaced. The dialog keeps full height; Retry sits bottom right.
Design notes
Stack
Depends on: #2699. Base:
review/collectives-version-comparison, retargets tomainonce #2699 merges. Final unit of six.Verification
lint(tsc + eslint) passes; unit suite 46/46, covering identity resolution, aliases, quarantine and every rejected input class. The route matrix (link copy, reload, Back, Forward, rename, malformed parameters) is covered by the live suite in the recorded runs (NC35 28/28, NC34 28/28). Missing IDs are never substituted. A fresh live pass with Viewer33dc36bais due before this leaves draft.Related
Happy to answer any questions in review.