Skip to content

fix: removed references to v-tooltip directive - #5602

Merged
hamza221 merged 1 commit into
nextcloud:mainfrom
madbob:fix_v_tooltip
Jul 31, 2026
Merged

fix: removed references to v-tooltip directive#5602
hamza221 merged 1 commit into
nextcloud:mainfrom
madbob:fix_v_tooltip

Conversation

@madbob

@madbob madbob commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The Tooltip directive has been deprecated in @nextcloud/vue in April 2025 and actually no longer inited in Contacts since the migration to Vue3.

Still, there are a few references generating tons of errors in the JS console.

Highlights:

  • removed #limit (including v-tooltip) and #no-options slots from the NcSelect of PropertyGroups: those were valid slots for the NcMultiselect components, replaced in 4205d1e with NcSelect
  • using plain title in SettingsAddressbook for the address books sharing button

Signed-off-by: Roberto Guido <info@madbob.org>
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hamza221 hamza221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment then good to go ✅

Comment thread src/components/Properties/PropertyGroups.vue
@hamza221

Copy link
Copy Markdown
Contributor

/backport to stable8.7

@hamza221
hamza221 merged commit 54ad234 into nextcloud:main Jul 31, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants